[
https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897639#comment-15897639
]
ASF GitHub Bot commented on FLINK-5778:
---------------------------------------
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3442
Thanks for your review Stefan! I addressed your comments, but only then
realized that the restriction to relative file state handle is actually a
problem for externalized checkpoints. :-( They possibly store their meta data
somewhere else and not as part of the checkpoint files. For them it's OK to not
be relocatable. Still, I agree with your comment that this should be more
explicitly allowed or disallowed. I gues that we should explicitly distinguish
between savepoints and externalized checkpoints for the meta data
serialization. I hope that Stephan's refactorings of the checkpoint stream
creation logic will help here. I'll leave this PR open with your suggested
changes and adjust it after Stephan's PR. Then I can either piggyback on his
changes or see whether I need to add the required distinction myself.
> Split FileStateHandle into fileName and basePath
> ------------------------------------------------
>
> Key: FLINK-5778
> URL: https://issues.apache.org/jira/browse/FLINK-5778
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> Store the statePath as a basePath and a fileName and allow to overwrite the
> basePath. We cannot overwrite the base path as long as the state handle is
> still in flight and not persisted. Otherwise we risk a resource leak.
> We need this in order to be able to relocate savepoints.
> {code}
> interface RelativeBaseLocationStreamStateHandle {
> void clearBaseLocation();
> void setBaseLocation(String baseLocation);
> }
> {code}
> FileStateHandle should implement this and the SavepointSerializer should
> forward the calls when a savepoint is stored or loaded, clear before store
> and set after load.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
