[
https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901258#comment-15901258
]
ASF GitHub Bot commented on FLINK-5778:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3442
Another thought from the discussion with @StefanRRichter :
You refactor a lot to not have duplicate code. While this is good in
general, I am wondering if we should not actually duplicate the code here,
because we want the `V1` serialization code and savepoint code to be
"immutable", meaning it should not be affected by changes to the `V2` code.
Having a copy makes sure no accidental changes are made to the `V1` code when
modifying the `V2` code.
> Split FileStateHandle into fileName and basePath
> ------------------------------------------------
>
> Key: FLINK-5778
> URL: https://issues.apache.org/jira/browse/FLINK-5778
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> Store the statePath as a basePath and a fileName and allow to overwrite the
> basePath. We cannot overwrite the base path as long as the state handle is
> still in flight and not persisted. Otherwise we risk a resource leak.
> We need this in order to be able to relocate savepoints.
> {code}
> interface RelativeBaseLocationStreamStateHandle {
> void clearBaseLocation();
> void setBaseLocation(String baseLocation);
> }
> {code}
> FileStateHandle should implement this and the SavepointSerializer should
> forward the calls when a savepoint is stored or loaded, clear before store
> and set after load.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
