[ 
https://issues.apache.org/jira/browse/FLINK-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899248#comment-15899248
 ] 

ASF GitHub Bot commented on FLINK-5481:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3127#discussion_r104641264
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/Types.java ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.typeutils;
    +
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
    +import org.apache.flink.api.common.typeinfo.SqlTimeTypeInfo;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +
    +import java.math.BigDecimal;
    +import java.sql.Date;
    +import java.sql.Time;
    +import java.sql.Timestamp;
    +
    +public class Types {
    +
    +   public static final BasicTypeInfo<String> STRING = 
BasicTypeInfo.STRING_TYPE_INFO;
    +   public static final BasicTypeInfo<Boolean> BOOLEAN = 
BasicTypeInfo.BOOLEAN_TYPE_INFO;
    +   public static final BasicTypeInfo<Byte> BYTE = 
BasicTypeInfo.BYTE_TYPE_INFO;
    +   public static final BasicTypeInfo<Short> SHORT = 
BasicTypeInfo.SHORT_TYPE_INFO;
    +   public static final BasicTypeInfo<Integer> INT = 
BasicTypeInfo.INT_TYPE_INFO;
    +   public static final BasicTypeInfo<Long> LONG = 
BasicTypeInfo.LONG_TYPE_INFO;
    +   public static final BasicTypeInfo<Float> FLOAT = 
BasicTypeInfo.FLOAT_TYPE_INFO;
    +   public static final BasicTypeInfo<Double> DOUBLE = 
BasicTypeInfo.DOUBLE_TYPE_INFO;
    +   public static final BasicTypeInfo<BigDecimal> DECIMAL = 
BasicTypeInfo.BIG_DEC_TYPE_INFO;
    +
    +   public static final SqlTimeTypeInfo<Date> DATE = SqlTimeTypeInfo.DATE;
    --- End diff --
    
    How about calling this `SQL_DATE`?


> Simplify Row creation
> ---------------------
>
>                 Key: FLINK-5481
>                 URL: https://issues.apache.org/jira/browse/FLINK-5481
>             Project: Flink
>          Issue Type: Bug
>          Components: DataSet API, Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Anton Solovev
>            Assignee: Anton Solovev
>            Priority: Trivial
>
> When we use {{ExecutionEnvironment#fromElements(X... data)}} it takes first 
> element of {{data}} to define a type. If first Row in collection has wrong 
> number of fields (there are nulls) TypeExtractor returns not RowTypeInfo, but 
> GenericType<Row>



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to