[ 
https://issues.apache.org/jira/browse/FLINK-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899273#comment-15899273
 ] 

ASF GitHub Bot commented on FLINK-5803:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3397#discussion_r104628040
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
 ---
    @@ -63,50 +62,28 @@ class DataStreamOverAggregate(
       }
     
       override def toString: String = {
    -    val (
    -      overWindow: Group,
    -      partitionKeys: Array[Int],
    -      namedAggregates: IndexedSeq[CalcitePair[AggregateCall, String]]
    -      ) = genPartitionKeysAndNamedAggregates
    -
    -    s"Aggregate(${
    -      if (!partitionKeys.isEmpty) {
    -        s"partitionBy: (${groupingToString(inputType, partitionKeys)}), "
    -      } else {
    -        ""
    -      }
    -    }window: ($overWindow), " +
    -      s"select: (${
    -        aggregationToString(
    -          inputType,
    -          partitionKeys,
    -          getRowType,
    -          namedAggregates,
    -          Seq())
    -      }))"
    +    s"OverAggregate(${aggOpName})"
       }
     
       override def explainTerms(pw: RelWriter): RelWriter = {
         val (
           overWindow: Group,
    -      partitionKeys: Array[Int],
    +      partition: Array[Int],
           namedAggregates: IndexedSeq[CalcitePair[AggregateCall, String]]
           ) = genPartitionKeysAndNamedAggregates
     
         super.explainTerms(pw)
    -      .itemIf("partitionBy", groupingToString(inputType, partitionKeys), 
!partitionKeys.isEmpty)
    -      .item("overWindow", overWindow)
    +      .itemIf("partitionBy", partitionToString(inputType, partition), 
partition.nonEmpty)
    +        .item("orderBy",orderingToString(inputType, 
overWindow.orderKeys.getFieldCollations))
    +      .item("range", windowRange(overWindow))
    --- End diff --
    
    ```
    .itemIf("rows", windowRange(overWindow), overWindow.isRows)
    .itemIf("range", windowRange(overWindow), !overWindow.isRows)
    ```



> Add [partitioned] processing time OVER RANGE BETWEEN UNBOUNDED PRECEDING 
> aggregation to SQL
> -------------------------------------------------------------------------------------------
>
>                 Key: FLINK-5803
>                 URL: https://issues.apache.org/jira/browse/FLINK-5803
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> The goal of this issue is to add support for OVER RANGE aggregations on 
> processing time streams to the SQL interface.
> Queries similar to the following should be supported:
> {code}
> SELECT 
>   a, 
>   SUM(b) OVER (PARTITION BY c ORDER BY procTime() RANGE BETWEEN UNBOUNDED 
> PRECEDING AND CURRENT ROW) AS sumB,
>   MIN(b) OVER (PARTITION BY c ORDER BY procTime() RANGE BETWEEN UNBOUNDED 
> PRECEDING AND CURRENT ROW) AS minB
> FROM myStream
> {code}
> The following restrictions should initially apply:
> - All OVER clauses in the same SELECT clause must be exactly the same.
> - The ORDER BY clause may only have procTime() as parameter. procTime() is a 
> parameterless scalar function that just indicates processing time mode.
> - bounded PRECEDING is not supported (see FLINK-5654)
> - FOLLOWING is not supported.
> The restrictions will be resolved in follow up issues. If we find that some 
> of the restrictions are trivial to address, we can add the functionality in 
> this issue as well.
> This issue includes:
> - Design of the DataStream operator to compute OVER ROW aggregates
> - Translation from Calcite's RelNode representation (LogicalProject with 
> RexOver expression).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to