[jira] [Commented] (FLINK-5976) Refactoring duplicate Tokenizer in flink-test

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902310#comment-15902310
 ] 

ASF GitHub Bot commented on FLINK-5976:
---------------------------------------

Github user liuyuzhong7 commented on the issue:

    https://github.com/apache/flink/pull/3485
  
    @StephanEwen It's a good idea. We can remove many duplicate code in 
flink-tests in this way.
    But I found it also duplicate in other modules. How to solve it in other 
modules.
    
![image](https://cloud.githubusercontent.com/assets/24708126/23732447/1f3cdd08-04ae-11e7-866e-a5a0e6d5e242.png)
    
    



> Refactoring duplicate Tokenizer in flink-test
> ---------------------------------------------
>
>                 Key: FLINK-5976
>                 URL: https://issues.apache.org/jira/browse/FLINK-5976
>             Project: Flink
>          Issue Type: Improvement
>          Components: Examples
>    Affects Versions: 1.2.0
>            Reporter: liuyuzhong7
>            Priority: Minor
>              Labels: test
>             Fix For: 1.2.0
>
>
> There are some duplicate code like this in flink-test, I think refactor this 
> will be better. 
> ```
> public final class Tokenizer implements FlatMapFunction<String, 
> Tuple2<String, Integer>> {
>       @Override
>       public void flatMap(String value, Collector<Tuple2<String, Integer>> 
> out) {
>               // normalize and split the line
>               String[] tokens = value.toLowerCase().split("\\W+");
>               // emit the pairs
>               for (String token : tokens) {
>                       if (token.length() > 0) {
>                               out.collect(new Tuple2<String, Integer>(token, 
> 1));
>                       }
>               }
>       }
> }
> ```



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)