[
https://issues.apache.org/jira/browse/FLINK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902736#comment-15902736
]
ASF GitHub Bot commented on FLINK-5976:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3485
I don't think it is necessary to unify all example functions. These are
just minimal non critical pieces defined by some tests. One we drop Java 7,
most of them will anyways disappear and become Lambdas. So I would not overdo
this right now...
> Refactoring duplicate Tokenizer in flink-test
> ---------------------------------------------
>
> Key: FLINK-5976
> URL: https://issues.apache.org/jira/browse/FLINK-5976
> Project: Flink
> Issue Type: Improvement
> Components: Examples
> Affects Versions: 1.2.0
> Reporter: liuyuzhong7
> Priority: Minor
> Labels: test
> Fix For: 1.2.0
>
>
> There are some duplicate code like this in flink-test, I think refactor this
> will be better.
> ```
> public final class Tokenizer implements FlatMapFunction<String,
> Tuple2<String, Integer>> {
> @Override
> public void flatMap(String value, Collector<Tuple2<String, Integer>>
> out) {
> // normalize and split the line
> String[] tokens = value.toLowerCase().split("\\W+");
> // emit the pairs
> for (String token : tokens) {
> if (token.length() > 0) {
> out.collect(new Tuple2<String, Integer>(token,
> 1));
> }
> }
> }
> }
> ```
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
