Github user clarkyzl commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3495#discussion_r105077753
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java ---
    @@ -137,6 +153,26 @@ public boolean hasDeprecatedKeys() {
                return deprecatedKeys == EMPTY ? 
Collections.<String>emptyList() : Arrays.asList(deprecatedKeys);
        }
     
    +   public String shortDescription() {
    +           return shortDescription;
    +   }
    +
    +   public String description() {
    +           return description;
    +   }
    +
    +   String toHTMLString(boolean includeShort) {
    +           String stringBuilder = "<tr>" +
    --- End diff --
    
    I think we should use `java.lang.StringBuilder`.
    
    ```java
    StringBuilder sb = new StringBuilder();
    sb.append("<tr>")
    .append("<td>").append(key).append("</td>");
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to