[ 
https://issues.apache.org/jira/browse/FLINK-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902401#comment-15902401
 ] 

ASF GitHub Bot commented on FLINK-5781:
---------------------------------------

Github user clarkyzl commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3495#discussion_r105077753
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java ---
    @@ -137,6 +153,26 @@ public boolean hasDeprecatedKeys() {
                return deprecatedKeys == EMPTY ? 
Collections.<String>emptyList() : Arrays.asList(deprecatedKeys);
        }
     
    +   public String shortDescription() {
    +           return shortDescription;
    +   }
    +
    +   public String description() {
    +           return description;
    +   }
    +
    +   String toHTMLString(boolean includeShort) {
    +           String stringBuilder = "<tr>" +
    --- End diff --
    
    I think we should use `java.lang.StringBuilder`.
    
    ```java
    StringBuilder sb = new StringBuilder();
    sb.append("<tr>")
    .append("<td>").append(key).append("</td>");
    ```


> Generation HTML from ConfigOption
> ---------------------------------
>
>                 Key: FLINK-5781
>                 URL: https://issues.apache.org/jira/browse/FLINK-5781
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Documentation
>            Reporter: Ufuk Celebi
>            Assignee: Dawid Wysakowicz
>
> Use the ConfigOption instances to generate a HTML page that we can use to 
> include in the docs configuration page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to