Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3466#discussion_r105124813
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
 ---
    @@ -97,6 +100,27 @@ public FsStateBackend(String checkpointDataUri) throws 
IOException {
         *
         * @param checkpointDataUri The URI describing the filesystem (scheme 
and optionally authority),
         *                          and the path to the checkpoint data 
directory.
    +    * @param asynchronousSnapshots Switch to enable asynchronous snapshots.
    +    *
    +    * @throws IOException Thrown, if no file system can be found for the 
scheme in the URI.
    +    */
    +   public FsStateBackend(String checkpointDataUri, boolean 
asynchronousSnapshots) throws IOException {
    --- End diff --
    
    We are getting a bit of a constructor explosion here (also because there 
are even more options coming with a pending refactoring on my side). Can we 
make this flag configurable by a setter instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to