Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105235710
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -419,6 +435,14 @@ public void merge(W mergeResult,
registerCleanupTimer(window);
}
}
+
+ // side output input event if
+ // element not handled by any window
+ // late arriving tag has been set
+ // windowAssigner is event time and current timestamp + allowed
lateness no less than element timestamp
+ if(isSkippedElement && lateDataOutputTag != null &&
isLate(element)) {
--- End diff --
Thanks @kl0u Good catch!
I put `isLate` there with intention to filter out `dropped events with
other reasons` which I may not aware of. lateArrivingEvents is really `late
arriving` and `dropped` events.
@aljoscha If that is redundant check, we might just remove `isLate`.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
