Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105400890
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -326,33 +327,48 @@ public int getChainLength() {
Map<Integer, StreamConfig> chainedConfigs,
ClassLoader userCodeClassloader,
Map<StreamEdge, RecordWriterOutput<?>> streamOutputs,
- List<StreamOperator<?>> allOperators)
+ List<StreamOperator<?>> allOperators,
+ OutputTag<IN> outputTag)
{
// create the output that the operator writes to first. this
may recursively create more operators
Output<StreamRecord<OUT>> output = createOutputCollector(
containingTask, operatorConfig, chainedConfigs,
userCodeClassloader, streamOutputs, allOperators);
// now create the operator and give it the output collector to
write its output to
OneInputStreamOperator<IN, OUT> chainedOperator =
operatorConfig.getStreamOperator(userCodeClassloader);
+
chainedOperator.setup(containingTask, operatorConfig, output);
allOperators.add(chainedOperator);
if (containingTask.getExecutionConfig().isObjectReuseEnabled())
{
- return new ChainingOutput<>(chainedOperator, this);
+ return new ChainingOutput<>(chainedOperator, this,
outputTag);
}
else {
TypeSerializer<IN> inSerializer =
operatorConfig.getTypeSerializerIn1(userCodeClassloader);
- return new CopyingChainingOutput<>(chainedOperator,
inSerializer, this);
+ return new CopyingChainingOutput<>(chainedOperator,
inSerializer, outputTag, this);
}
}
private <T> RecordWriterOutput<T> createStreamOutput(
StreamEdge edge, StreamConfig upStreamConfig, int
outputIndex,
Environment taskEnvironment,
- String taskName)
- {
- TypeSerializer<T> outSerializer =
upStreamConfig.getTypeSerializerOut(taskEnvironment.getUserClassLoader());
+ String taskName) {
+ OutputTag sideOutputTag = edge.getOutputTag(); // OutputTag,
return null if not sideOutput
+
+ TypeSerializer outSerializer = null;
+
--- End diff --
too much line breaking in the following `if() else()` . We could easily
reduce it or even replace it with:
```
TypeSerializer outSerializer = (edge.getOutputTag() != null) ?
upStreamConfig.getTypeSerializerSideOut(edge.getOutputTag(),
taskEnvironment.getUserClassLoader()) :
upStreamConfig.getTypeSerializerOut(taskEnvironment.getUserClassLoader());
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
