[
https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905376#comment-15905376
]
ASF GitHub Bot commented on FLINK-6008:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/3512
[FLINK-6008] collection of BlobServer improvements
This PR improves the following things around the `BlobServer`/`BlobCache`:
* replaces config uptions in `config.md` with non-deprecated ones, e.g.
`high-availability.cluster-id` and `high-availability.storageDir`
* promote `BlobStore#deleteAll(JobID)` to the `BlobService`
* extend the `BlobService` to work with `NAME_ADDRESSABLE` blobs (prepares
for FLINK-4399]
* remove `NAME_ADDRESSABLE` blobs after job/task termination
* add more unit tests for `NAME_ADDRESSABLE` blobs
* do not fail the `BlobServer` when a delete operation fails
* general code style and docs improvements, like using
`Preconditions.checkArgument`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-6008
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3512
----
commit 8cfbe97df3f7c8fa268f5c19291174a99e3cf943
Author: Nico Kruber <n...@data-artisans.com>
Date: 2016-12-20T15:49:57Z
[FLINK-6008][docs] minor improvements in the BlobService docs
commit a72b31474fd38f27e5cc582b3c2797fa51695e38
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-01-06T17:42:58Z
[FLINK-6008][docs] update some config options to the new, non-deprecated
ones
commit a6af4e0b393a8684984a6adada7e6eff4f99ac18
Author: Nico Kruber <n...@data-artisans.com>
Date: 2016-12-20T17:27:13Z
[FLINK-6008] refactor BlobCache#getURL() for cleaner code
commit 69247739e127f8c941e352c07a0be6e03ecea1d1
Author: Nico Kruber <n...@data-artisans.com>
Date: 2016-12-20T17:52:19Z
[FLINK-6008] extend the BlobService to the NAME_ADDRESSABLE blobs
These blobs are referenced by the job ID and a selected name instead of the
hash sum of the blob's contents. Some code was already prepared but lacked
the proper additions in further APIs. This commit adds some.
commit 9913ae86b854e1c5b3dca404824ab9a70cc32db6
Author: Nico Kruber <n...@data-artisans.com>
Date: 2016-12-21T15:23:29Z
[FLINK-6008] promote BlobStore#deleteAll(JobID) to the BlobService
commit d96e6d43ac637149e9d1077c6dee3801d30f679a
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-03-09T17:14:02Z
[FLINK-6008] use Preconditions.checkArgument in BlobClient
commit 6d53e3ff87110601eb1a71d60f850e6089930141
Author: Nico Kruber <n...@data-artisans.com>
Date: 2016-12-21T16:59:27Z
[FLINK-6008] properly remove NAME_ADDRESSABLE blobs after job/task
termination
commit 5ef5a74db3f6753437b585823b037e25e23a61ba
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-03-09T18:14:52Z
[FLINK-6008] more unit tests for NAME_ADDRESSABLE and BlobService access
NAME_ADDRESSABLE blobs were not that thouroughly tested before and also the
access methods that the BlobService implementations provide. This adds tests
covering both.
commit 34857456a43ec5a2ccb5166bd379f263cd54697d
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-03-09T17:15:08Z
[FLINK-6008] do not fail the BlobServer when delete fails
This also enables us to reuse some more code between BlobServerConnection
and
BlobServer.
commit e55ab0f37005ef37065b8156f59e4b8db1a7b95f
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-03-09T17:32:14Z
[FLINK-6008] refactor BlobCache#deleteGlobal() for cleaner code
----
> collection of BlobServer improvements
> -------------------------------------
>
> Key: FLINK-6008
> URL: https://issues.apache.org/jira/browse/FLINK-6008
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.3.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> The following things should be improved around the BlobServer/BlobCache:
> * update config uptions with non-deprecated ones, e.g.
> {{high-availability.cluster-id}} and {{high-availability.storageDir}}
> * promote {{BlobStore#deleteAll(JobID)}} to the {{BlobService}}
> * extend the {{BlobService}} to work with {{NAME_ADDRESSABLE}} blobs
> (prepares FLINK-4399]
> * remove {{NAME_ADDRESSABLE}} blobs after job/task termination
> * do not fail the {{BlobServer}} when a delete operation fails
> * code style, like using {{Preconditions.checkArgument}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
