[ 
https://issues.apache.org/jira/browse/FLINK-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907645#comment-15907645
 ] 

ASF GitHub Bot commented on FLINK-3398:
---------------------------------------

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/3527

    [FLINK-3398] [kafka] Allow disabling offset committing for 
FlinkKafkaConsumer

    This PR allows users to completely disable offset committing back to Kafka.
    
    The way configuration works depends on whether checkpointing was enabled 
for the job:
    
    - **Checkpointing disabled:** when checkpointing is disabled, the consumer 
relies on the auto commit functionality of internal Kafka clients. Therefore, 
to disable / enable offset committing, users simply need to set appropriate 
values for `auto.commit.enable` / `auto.commit.interval.ms`.
    
    - **Checkpointing enabled:** in this scenario, the `auto.commit.enable` / 
`auto.commit.interval.ms` is completely ignored. To disable / enable offset 
committing, users use a new `setCommiOffsetsOnCheckpoints(boolean)` method. By 
default, this is `true`, so that without any additional configuration, the 
committing behaviour sticks with the original consumer prior to this change. No 
user code / behaviour is broken.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-3398

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3527
    
----
commit 1163d82c908423c941f6b8d71c9019c7c33ba6ab
Author: Tzu-Li (Gordon) Tai <[email protected]>
Date:   2017-03-13T05:49:08Z

    [FLINK-3398] [kafka] Allow disabling offset committing for 
FlinkKafkaConsumer

----


> Flink Kafka consumer should support auto-commit opt-outs
> --------------------------------------------------------
>
>                 Key: FLINK-3398
>                 URL: https://issues.apache.org/jira/browse/FLINK-3398
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Shikhar Bhushan
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Critical
>             Fix For: 1.3.0
>
>
> Currently the Kafka source will commit consumer offsets to Zookeeper, either 
> upon a checkpoint if checkpointing is enabled, otherwise periodically based 
> on {{auto.commit.interval.ms}}
> It should be possible to opt-out of committing consumer offsets to Zookeeper. 
> Kafka has this config as {{auto.commit.enable}} (0.8) and 
> {{enable.auto.commit}} (0.9).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to