[ 
https://issues.apache.org/jira/browse/FLINK-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924511#comment-15924511
 ] 

ASF GitHub Bot commented on FLINK-3398:
---------------------------------------

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3527
  
    Did a final test run on a Kafka installation, and things worked as expected.
    One minor improvement would be to add logs for what exactly the commit mode 
is used when it is determined in `open()`.
    
    I think it's a safe call to add the log and then merge this :-) Will 
proceed to merge for `master`.
    Thanks for all the recent reviews @rmetzger :-D


> Flink Kafka consumer should support auto-commit opt-outs
> --------------------------------------------------------
>
>                 Key: FLINK-3398
>                 URL: https://issues.apache.org/jira/browse/FLINK-3398
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Shikhar Bhushan
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Critical
>             Fix For: 1.3.0
>
>
> Currently the Kafka source will commit consumer offsets to Zookeeper, either 
> upon a checkpoint if checkpointing is enabled, otherwise periodically based 
> on {{auto.commit.interval.ms}}
> It should be possible to opt-out of committing consumer offsets to Zookeeper. 
> Kafka has this config as {{auto.commit.enable}} (0.8) and 
> {{enable.auto.commit}} (0.9).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to