[
https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923432#comment-15923432
]
ASF GitHub Bot commented on FLINK-3849:
---------------------------------------
Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r105811515
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -42,63 +41,40 @@ class DataSetCalc(
traitSet: RelTraitSet,
input: RelNode,
rowRelDataType: RelDataType,
- private[flink] val calcProgram: RexProgram, // for tests
+ calcProgram: RexProgram,
ruleDescription: String)
- extends SingleRel(cluster, traitSet, input)
+ extends Calc(cluster, traitSet, input, calcProgram)
with CommonCalc
with DataSetRel {
- override def deriveRowType() = rowRelDataType
+ override def deriveRowType(): RelDataType = rowRelDataType
- override def copy(traitSet: RelTraitSet, inputs:
java.util.List[RelNode]): RelNode = {
- new DataSetCalc(
- cluster,
- traitSet,
- inputs.get(0),
- getRowType,
- calcProgram,
- ruleDescription)
+ override def copy(traitSet: RelTraitSet, child: RelNode, program:
RexProgram): Calc = {
+ new DataSetCalc(cluster, traitSet, child, getRowType, program,
ruleDescription)
}
override def toString: String = calcToString(calcProgram,
getExpressionString)
override def explainTerms(pw: RelWriter): RelWriter = {
- super.explainTerms(pw)
- .item("select", selectionToString(calcProgram, getExpressionString))
- .itemIf("where",
- conditionToString(calcProgram, getExpressionString),
- calcProgram.getCondition != null)
+ pw.input("input", getInput)
+ .item("select", selectionToString(calcProgram,
getExpressionString))
--- End diff --
two spaces for indention
> Add FilterableTableSource interface and translation rule
> --------------------------------------------------------
>
> Key: FLINK-3849
> URL: https://issues.apache.org/jira/browse/FLINK-3849
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Kurt Young
>
> Add a {{FilterableTableSource}} interface for {{TableSource}} implementations
> which support filter push-down.
> The interface could look as follows
> {code}
> def trait FilterableTableSource {
> // returns unsupported predicate expression
> def setPredicate(predicate: Expression): Expression
> }
> {code}
> In addition we need Calcite rules to push a predicate (or parts of it) into a
> TableScan that refers to a {{FilterableTableSource}}. We might need to tweak
> the cost model as well to push the optimizer in the right direction.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
