Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106544854
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,6 +137,10 @@ class DataStreamOverAggregate(
if (overWindow.lowerBound.isUnbounded &&
overWindow.upperBound.isCurrentRow) {
createUnboundedAndCurrentRowProcessingTimeOverWindow(inputDS)
+ } else if
(overWindow.lowerBound.getOffset.getType.isInstanceOf[IntervalSqlType]
--- End diff --
We can explicitly check if a window is a ROW or a RANGE window by
`overWindow.isRows`. I'm also not sure about the
`overWindow.upperBound.isPreceding` condition.
I think the condition rather be like this:
```
else if (overWindow.lowerBound.isPreceding() &&
!overWindow.lowerBound.isUnbounded() && // bounded preceding
overWindow.upperBound.isCurrentRow() && // until current row
!overWindow.isRows) // is RANGE window
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
