Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106659524
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,6 +137,10 @@ class DataStreamOverAggregate(
if (overWindow.lowerBound.isUnbounded &&
overWindow.upperBound.isCurrentRow) {
createUnboundedAndCurrentRowProcessingTimeOverWindow(inputDS)
+ } else if
(overWindow.lowerBound.getOffset.getType.isInstanceOf[IntervalSqlType]
--- End diff --
@fhueske
As a personal preference I like to have the conditions as explicit as
possible just to make sure it will not trigger in undesirable cases. I did not
knew about the isRows() function...of course I can check that.
Regarding the upper bound my reasoning was that if we will support other
constructs in the future -e.g. FOLLOWING, fixed time boundaries...whatever else
will be invented... it is much easier to integrate those if we have this
explicit check now..rather then searching for it at that moment
However, if you prefer it removed of course it is not hard to do that :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
