[
https://issues.apache.org/jira/browse/FLINK-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930381#comment-15930381
]
ASF GitHub Bot commented on FLINK-6050:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3537
I think this is good, +1
Do we have a test that validates that completing a `Future` exceptionally
also completes all result Futures of `thenApply` (or `thenApplyAsync`)
functions with an exception?
> Improve failure reporting when using Future.thenAccept
> ------------------------------------------------------
>
> Key: FLINK-6050
> URL: https://issues.apache.org/jira/browse/FLINK-6050
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> When applying {{Future.thenAccept(Async)}} onto a {{Future}}, then we should
> register the exception handler on the returned {{Future<Void>}} and not on
> the original future. This has the advantage that we also catch exceptions
> which are thrown in the {{AcceptFunction}} and not only those originating
> from the original {{Future}}. This improve Flink's behaviour, because
> exceptions are not swallowed in the returned {{Future}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
