Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3573#discussion_r106959941
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -198,6 +204,14 @@ public boolean isShutdown() {
* Shuts down this registry and the associated {@link MetricReporter}.
*/
public void shutdown() {
+ Future<Boolean> stopFuture = null;
--- End diff --
why do you split the additions in 2 blocks? Could you not merge them with
the sole condition that the MQS is not null?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
