Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3573#discussion_r107615168
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -209,14 +223,29 @@ public void shutdown() {
reporters = null;
}
shutdownExecutor();
+
+ if (stopFuture != null) {
--- End diff --
if the MQS is started while a shutdown is in progress it might not be
cleaned up. What do you think about adding a lock here and in
startMetricQueryService?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
