Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107026831
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object AggregateUtil {
(propPos._1, propPos._2)
}
- private def transformToAggregateFunctions(
--- End diff --
I'm OK with making this method `private[flink]`. @shijinkui is right, that
this is more visible than necessary but on the other hand, many other methods
of the Table API have been declared `private[flink]` as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
