Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107025846
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -239,4 +252,179 @@ class WindowAggregateTest extends TableTestBase {
)
streamUtil.verifySql(sql, expected)
}
+
+ @Test
+ def testMaxAggregatation(): Unit = {
--- End diff --
The aggregation functions are separately checked. We do not need tests that
validate that each type of aggregation works with all types of aggregation
functions.
Moreover, the tests in this class do not execute any query but validate
that the correct plan is produced. Please have a look at the other test methods
and adapt your tests accordingly. I think two tests (partitioned and
non-partitioned) with multiple aggregates should be sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
