Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3531#discussion_r107411558
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
---
@@ -306,6 +307,29 @@ private static void
assignTaskStatesToOperatorInstances(
}
/**
+ * Determine the subset of {@link KeyGroupsStateHandle
KeyGroupsStateHandles} with correct
+ * key group index for the given subtask {@link KeyGroupRange}.
+ * <p>
+ * <p>This is publicly visible to be used in tests.
+ */
+ public static List<KeyedStateHandle> getKeyedStateHandles(
--- End diff --
Could we completely remove `getKeyGroupsStateHandles()` and remove
everything with this method that works on `KeyedStateHandle`? This includes
using also only `KeyedStateHandle` for the raw keyed state that is checkpointed
into streams (without backend). Otherwise, this is almost duplicated code. What
do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
