Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3531#discussion_r107874353
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ---
    @@ -761,6 +769,13 @@ private void restoreKVStateMetaData() throws 
IOException, ClassNotFoundException
                private void restoreKVStateData() throws IOException, 
RocksDBException {
                        //for all key-groups in the current state handle...
                        for (Tuple2<Integer, Long> keyGroupOffset : 
currentKeyGroupsStateHandle.getGroupRangeOffsets()) {
    +                           int keyGroup = keyGroupOffset.f0;
    +
    +                           // Skip those key groups that do not belong to 
the backend
    +                           if 
(!rocksDBKeyedStateBackend.getKeyGroupRange().contains(keyGroup)) {
    --- End diff --
    
    The same comment I had on the `HeapKeyedStateBackend` also applies here: I 
think the post-filter is no longer required after the change i suggested for 
`StateAssignmentOperation`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to