Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3603#discussion_r107692914
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -368,18 +388,29 @@ public void
testBackendUsesRegisteredKryoSerializerUsingGetOrCreate() throws Exc
}
try {
+ // backends that lazily serializes (such as memory
state backend) will fail here
runSnapshot(backend.snapshot(682375462378L, 2,
streamFactory, CheckpointOptions.forFullCheckpoint()));
} catch (ExpectedKryoTestException e) {
numExceptions++;
+ } catch (Exception e) {
+ if (e.getCause() instanceof ExpectedKryoTestException) {
+ numExceptions++;
+ } else {
+ throw e;
+ }
}
assertEquals("Didn't see the expected Kryo exception.", 1,
numExceptions);
}
/**
- * Verify that we can restore a snapshot that was done with without
registered types
- * after registering types.
+ * Verify state restore resilience when:
+ * - snapshot was taken without any Kryo registrations, specific
serializers or default serializers for the state type
+ * - restored with the state type registered (no specific serializer)
+ *
+ * This test should not fail, because de- / serialization of the state
should noth be performed with Kryo's default
--- End diff --
Typo: noth
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
