[
https://issues.apache.org/jira/browse/FLINK-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942226#comment-15942226
]
ASF GitHub Bot commented on FLINK-6188:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3616
[FLINK-6188] Correctly handle PARALLELISM_DEFAULT in stream operator
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira-6188-set-parallelism
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3616.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3616
----
commit 40ca699cc1f6b00d6d50b16d6833794c5362dbb1
Author: Aljoscha Krettek <[email protected]>
Date: 2017-03-26T10:23:01Z
[FLINK-6188] Handle PARALLELISM_DEFAULT in setParallelism()
SingleOutputStreamOperator.setParallelism() and
StreamTransform.setParallelism() did not correctly handle the case of
setting the parallelism to PARALLELISM_DEFAULT.
commit 9107a3400af877ddfefcc0f5b16cc6b03127ec76
Author: Aljoscha Krettek <[email protected]>
Date: 2017-03-26T10:24:58Z
[FLINK-6188] Add TimestampAssignerTranslationTest
The tests verify that we instantiate the correct operator and that they
correctly pick up the parallelism form the upstream operator.
----
> Some setParallelism() methods can't cope with default parallelism
> -----------------------------------------------------------------
>
> Key: FLINK-6188
> URL: https://issues.apache.org/jira/browse/FLINK-6188
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
> Affects Versions: 1.2.1
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
> Fix For: 1.2.1
>
>
> Recent changes done for FLINK-5808 move default parallelism manifestation
> from eager to lazy, that is, the parallelism of operations that don't have an
> explicit parallelism is only set when generating the JobGraph. Some
> {{setParallelism()}} calls, such as
> {{SingleOutputStreamOperator.setParallelism()}} cannot deal with the fact
> that the parallelism of an operation might be {{-1}} (which indicates that it
> should take the default parallelism when generating the JobGraph).
> We should either revert the changes that fixed another user-facing bug for
> version 1.2.1 or fix the methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
