[
https://issues.apache.org/jira/browse/FLINK-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949276#comment-15949276
]
ASF GitHub Bot commented on FLINK-6188:
---------------------------------------
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3616#discussion_r108956486
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/StreamTransformation.java
---
@@ -202,7 +203,17 @@ public int getParallelism() {
* @param parallelism The new parallelism to set on this {@code
StreamTransformation}
*/
public void setParallelism(int parallelism) {
- Preconditions.checkArgument(parallelism > 0, "Parallelism must
be bigger than zero.");
+ checkArgument(parallelism !=
ExecutionConfig.PARALLELISM_UNKNOWN, "Cannot specify UNKNOWN_PARALLELISM.");
--- End diff --
@greghogan I see. so I suppose we could remove it. This will simplify the
checks here a bit.
> Some setParallelism() methods can't cope with default parallelism
> -----------------------------------------------------------------
>
> Key: FLINK-6188
> URL: https://issues.apache.org/jira/browse/FLINK-6188
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
> Affects Versions: 1.2.1
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
> Fix For: 1.2.1
>
>
> Recent changes done for FLINK-5808 move default parallelism manifestation
> from eager to lazy, that is, the parallelism of operations that don't have an
> explicit parallelism is only set when generating the JobGraph. Some
> {{setParallelism()}} calls, such as
> {{SingleOutputStreamOperator.setParallelism()}} cannot deal with the fact
> that the parallelism of an operation might be {{-1}} (which indicates that it
> should take the default parallelism when generating the JobGraph).
> We should either revert the changes that fixed another user-facing bug for
> version 1.2.1 or fix the methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
