Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3408#discussion_r108417249
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -164,6 +164,12 @@ public AbstractYarnClusterDescriptor() {
throw new RuntimeException("Unable to locate
configuration file in " + confFile);
}
flinkConfigurationPath = new
Path(confFile.getAbsolutePath());
+
+ if
(flinkConfiguration.containsKey(ConfigConstants.YARN_VCORES)) {
+ slots =
flinkConfiguration.getInteger(ConfigConstants.YARN_VCORES, -1);
+ } else if
(flinkConfiguration.containsKey(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS)) {
+ slots =
flinkConfiguration.getInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, -1);
+ }
--- End diff --
I think we should make the behaviour consistent with Mesos and standalone
where we set `slots =
flinkConfiguration.getInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, 1)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
