Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3408#discussion_r108417410
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
    @@ -335,8 +335,7 @@ protected void requestNewWorkers(int numWorkers) {
                        Priority priority = Priority.newInstance(0);
     
                        // Resource requirements for worker containers
    -                   int taskManagerSlots = taskManagerParameters.numSlots();
    -                   int vcores = 
config.getInteger(ConfigConstants.YARN_VCORES, Math.max(taskManagerSlots, 1));
    +                   int vcores = Math.max(taskManagerParameters.numSlots(), 
1);
    --- End diff --
    
    I think we should still keep the possibility open to configure the `vcores` 
explicitly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to