[
https://issues.apache.org/jira/browse/FLINK-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945134#comment-15945134
]
ASF GitHub Bot commented on FLINK-5903:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3408#discussion_r108417249
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -164,6 +164,12 @@ public AbstractYarnClusterDescriptor() {
throw new RuntimeException("Unable to locate
configuration file in " + confFile);
}
flinkConfigurationPath = new
Path(confFile.getAbsolutePath());
+
+ if
(flinkConfiguration.containsKey(ConfigConstants.YARN_VCORES)) {
+ slots =
flinkConfiguration.getInteger(ConfigConstants.YARN_VCORES, -1);
+ } else if
(flinkConfiguration.containsKey(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS)) {
+ slots =
flinkConfiguration.getInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, -1);
+ }
--- End diff --
I think we should make the behaviour consistent with Mesos and standalone
where we set `slots =
flinkConfiguration.getInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, 1)`.
> taskmanager.numberOfTaskSlots and yarn.containers.vcores did not work well in
> YARN mode
> ---------------------------------------------------------------------------------------
>
> Key: FLINK-5903
> URL: https://issues.apache.org/jira/browse/FLINK-5903
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Reporter: Tao Wang
> Assignee: Tao Wang
> Attachments: set taskmanager.numberOfTaskSlots to 6.JPG, set
> yarn.container.vcores to 5_JM.JPG, set yarn.container.vcores to 5_RM.JPG
>
>
> Now Flink did not respect taskmanager.numberOfTaskSlots and
> yarn.containers.vcores in flink-conf.yaml, but only -s parameter in CLI.
> Details is that taskmanager.numberOfTaskSlots is not working in anyway
> andyarn.containers.vcores is only used in requesting container(TM) resources
> but not aware to TM, which means TM will always think it has default(1) Slots
> if -s is not configured.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
