[
https://issues.apache.org/jira/browse/FLINK-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945133#comment-15945133
]
ASF GitHub Bot commented on FLINK-5903:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3408#discussion_r108417410
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -335,8 +335,7 @@ protected void requestNewWorkers(int numWorkers) {
Priority priority = Priority.newInstance(0);
// Resource requirements for worker containers
- int taskManagerSlots = taskManagerParameters.numSlots();
- int vcores =
config.getInteger(ConfigConstants.YARN_VCORES, Math.max(taskManagerSlots, 1));
+ int vcores = Math.max(taskManagerParameters.numSlots(),
1);
--- End diff --
I think we should still keep the possibility open to configure the `vcores`
explicitly.
> taskmanager.numberOfTaskSlots and yarn.containers.vcores did not work well in
> YARN mode
> ---------------------------------------------------------------------------------------
>
> Key: FLINK-5903
> URL: https://issues.apache.org/jira/browse/FLINK-5903
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Reporter: Tao Wang
> Assignee: Tao Wang
> Attachments: set taskmanager.numberOfTaskSlots to 6.JPG, set
> yarn.container.vcores to 5_JM.JPG, set yarn.container.vcores to 5_RM.JPG
>
>
> Now Flink did not respect taskmanager.numberOfTaskSlots and
> yarn.containers.vcores in flink-conf.yaml, but only -s parameter in CLI.
> Details is that taskmanager.numberOfTaskSlots is not working in anyway
> andyarn.containers.vcores is only used in requesting container(TM) resources
> but not aware to TM, which means TM will always think it has default(1) Slots
> if -s is not configured.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
