[
https://issues.apache.org/jira/browse/FLINK-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947212#comment-15947212
]
ASF GitHub Bot commented on FLINK-6211:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3636
Hi @tsriharsha!
First of all, thanks a lot for reporting this bug. Contributions in Flink,
however, require a corresponding JIRA ticket. In the future, I would recommend
always opening a JIRA before the pull request so that other contributors will
know that the issue is worked on already (and would therefore avoid race
conditions / duplicate work like right now :-D).
Generally, the implementation #3637 is cleaner and includes tests for the
fix. I think I'll proceed with FLINK-6211 using the patch in #3637. Hope you
understand, and welcome more contributions!
> Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position
> ------------------------------------------------------------------------------
>
> Key: FLINK-6211
> URL: https://issues.apache.org/jira/browse/FLINK-6211
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
> Reporter: Wei-Che Wei
> Assignee: Wei-Che Wei
> Priority: Blocker
> Fix For: 1.3.0, 1.2.1
>
>
> {code}
> private static void validateOptionalDateProperty(Properties config, String
> key, String message) {
> if (config.containsKey(key)) {
> try {
> initTimestampDateFormat.parse(config.getProperty(key)); —
> double value = Double.parseDouble(config.getProperty(key)); —
> if (value < 0) { throw new NumberFormatException(); }
> } catch (ParseException | NumberFormatException e){
> throw new IllegalArgumentException(message); }
> }
> }
> }
> {code}
> This validation function will always fail regardless of either string format
> or double type.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
