[
https://issues.apache.org/jira/browse/FLINK-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947863#comment-15947863
]
ASF GitHub Bot commented on FLINK-5915:
---------------------------------------
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3647
[FLINK-5915] [table] forward the entire aggregate ArgList to aggregate
runtime functions
This PR partially solved "FLINK-5915 Add support for the aggregate on multi
fields".
The roadmap of UDAGG would be 1. codeGen all the runtime aggregate
functions; 2. add UDAGG tableAPI interface.
I would like to kick this PR off earlier as: a) we can finalize the runtime
function while doing the codeGen; b) as more and more (over) aggregates are
implemented, it would be good if we can finalize the interface and share
library to the stage (as we planned) as earlier as possible.
Note that: though the entire aggregate ArgList is forwarded to the runtime
function, for the functions that have not been codeGened, we will still support
only one column aggregate input.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shaoxuan-wang/flink FLINK5915-submit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3647
----
commit 128479c24003e8f0bd67542f336f9ae20dade352
Author: shaoxuan-wang <[email protected]>
Date: 2017-03-29T20:41:38Z
[FLINK-5915] [table] forward the entire aggregate ArgList to aggregate
runtime functions
----
> Add support for the aggregate on multi fields
> ---------------------------------------------
>
> Key: FLINK-5915
> URL: https://issues.apache.org/jira/browse/FLINK-5915
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> some UDAGGs have multi-fields as input. For instance,
> table
> .window(Tumble over 10.minutes on 'rowtime as 'w )
> .groupBy('key, 'w)
> .select('key, weightedAvg('value, 'weight))
> This task will add the support for the aggregate on multi fields.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
