[
https://issues.apache.org/jira/browse/FLINK-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949769#comment-15949769
]
ASF GitHub Bot commented on FLINK-5915:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3647#discussion_r109032005
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -857,28 +857,30 @@ object AggregateUtil {
aggregateCalls: Seq[AggregateCall],
inputType: RelDataType,
needRetraction: Boolean)
- : (Array[Int], Array[TableAggregateFunction[_ <: Any]]) = {
+ : (Array[util.List[Integer]], Array[TableAggregateFunction[_ <: Any]]) =
{
--- End diff --
Can we use an `Array[Int]` instead of a `List[Integer]`?
Scala `Int` is compiled to Java `int` primitive. `java.lang.Integer` is a
boxed type.
Also an array access is faster than a `List.get()` access
(`ArrayList.get()` would be a bit better).
> Add support for the aggregate on multi fields
> ---------------------------------------------
>
> Key: FLINK-5915
> URL: https://issues.apache.org/jira/browse/FLINK-5915
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> some UDAGGs have multi-fields as input. For instance,
> table
> .window(Tumble over 10.minutes on 'rowtime as 'w )
> .groupBy('key, 'w)
> .select('key, weightedAvg('value, 'weight))
> This task will add the support for the aggregate on multi fields.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
