[ 
https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949142#comment-15949142
 ] 

ASF GitHub Bot commented on FLINK-5823:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3522#discussion_r108729089
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryStateBackend.java
 ---
    @@ -18,33 +18,89 @@
     
     package org.apache.flink.runtime.state.memory;
     
    +import org.apache.flink.annotation.PublicEvolving;
     import org.apache.flink.api.common.JobID;
     import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.core.fs.FileStatus;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.runtime.checkpoint.CompletedCheckpoint;
     import org.apache.flink.runtime.execution.Environment;
     import org.apache.flink.runtime.query.TaskKvStateRegistry;
     import org.apache.flink.runtime.state.AbstractKeyedStateBackend;
    -import org.apache.flink.runtime.state.AbstractStateBackend;
     import org.apache.flink.runtime.state.CheckpointStreamFactory;
    +import org.apache.flink.runtime.state.ConfigurableStateBackend;
     import org.apache.flink.runtime.state.KeyGroupRange;
    +import org.apache.flink.runtime.state.filesystem.AbstractFileStateBackend;
     import org.apache.flink.runtime.state.heap.HeapKeyedStateBackend;
    +import org.apache.flink.util.FlinkException;
    +
    +import javax.annotation.Nullable;
     
     import java.io.IOException;
     
    +import static org.apache.flink.util.Preconditions.checkArgument;
    +
     /**
    - * A {@link AbstractStateBackend} that stores all its data and checkpoints 
in memory and has no
    - * capabilities to spill to disk. Checkpoints are serialized and the 
serialized data is
    - * transferred
    + * This state backend holds the working state in the memory (JVM heap) of 
the TaskManagers.
    + * The state backend checkpoints state directly the JobManager's memory 
(hence the backend's name),
    --- End diff --
    
    preposition seems to be missing here


> Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
> -----------------------------------------------------------------------
>
>                 Key: FLINK-5823
>                 URL: https://issues.apache.org/jira/browse/FLINK-5823
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to