[ 
https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949145#comment-15949145
 ] 

ASF GitHub Bot commented on FLINK-5823:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3522#discussion_r108469205
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV1.java
 ---
    @@ -61,10 +61,24 @@ public long getCheckpointId() {
     
        @Override
        public void dispose() throws Exception {
    +           Exception firstException = null;
    +
                for (TaskState taskState : taskStates) {
    -                   taskState.discardState();
    +                   try {
    +                           taskState.discardState();
    +                   }
    +                   catch (Exception e) {
    +                           if (firstException == null) {
    +                                   firstException = e;
    --- End diff --
    
    We could add all following exceptions as suppressed exceptions.


> Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
> -----------------------------------------------------------------------
>
>                 Key: FLINK-5823
>                 URL: https://issues.apache.org/jira/browse/FLINK-5823
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to