Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3522#discussion_r108728575
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackendFactory.java
---
@@ -18,44 +18,47 @@
package org.apache.flink.runtime.state.filesystem;
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.IllegalConfigurationException;
import org.apache.flink.core.fs.Path;
import org.apache.flink.runtime.state.StateBackendFactory;
-import java.io.IOException;
+import java.net.URI;
/**
- * A factory that creates an {@link
org.apache.flink.runtime.state.filesystem.FsStateBackend}
- * from a configuration.
+ * A factory that creates an {@link FsStateBackend} from a configuration.
*/
+@PublicEvolving
public class FsStateBackendFactory implements
StateBackendFactory<FsStateBackend> {
-
- /** The key under which the config stores the directory where
checkpoints should be stored */
- public static final String CHECKPOINT_DIRECTORY_URI_CONF_KEY =
"state.backend.fs.checkpointdir";
- /** The key under which the config stores the threshold for state to be
store in memory,
- * rather than in files */
- public static final String MEMORY_THRESHOLD_CONF_KEY =
"state.backend.fs.memory-threshold";
+ /** Config key for the maximum state size that is stored with the
metadata */
+ public static final ConfigOption<Integer> MEMORY_THRESHOLD_CONF =
ConfigOptions
--- End diff --
I'm wondering whether we want to group all relevant state options into a
dedicated `StateOptions` class or keep them in the respective class where they
are used. I fear that it will be quite hard for the user to find all available
options.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
