Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3616#discussion_r108943194
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
 ---
    @@ -50,6 +52,83 @@
     @SuppressWarnings("serial")
     public class StreamingJobGraphGeneratorTest extends TestLogger {
     
    --- End diff --
    
    I would suggest to add some tests (the same code as the existing ones) with 
invalid configurations and the expected exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to