[
https://issues.apache.org/jira/browse/FLINK-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949322#comment-15949322
]
ASF GitHub Bot commented on FLINK-6175:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3655
[FLINK-6175] Harden HistoryServerTest#testFullArchiveLifecycle
This PR hardens the `testFullArchiveLifecycle` test by introducing an
optional `CountdownLatch` argument to the HistoryServer constructor This latch
is updated after each finished archive poll, regardless of whether it failed or
not.
This simplifies the test and removes edge cases where the requested file
already exists but the contents weren't written yet.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6175_hs_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3655.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3655
----
commit 3e491a532330476ecf05f2eb319a95212569b52d
Author: zentol <[email protected]>
Date: 2017-03-23T12:58:03Z
[FLINK-6175] Harden HistoryServerTest#testFullArchiveLifecycle
----
> HistoryServerTest.testFullArchiveLifecycle fails
> ------------------------------------------------
>
> Key: FLINK-6175
> URL: https://issues.apache.org/jira/browse/FLINK-6175
> Project: Flink
> Issue Type: Test
> Components: Tests, Webfrontend
> Reporter: Ufuk Celebi
> Assignee: Chesnay Schepler
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/213933823/log.txt
> {code}
> estFullArchiveLifecycle(org.apache.flink.runtime.webmonitor.history.HistoryServerTest)
> Time elapsed: 2.162 sec <<< FAILURE!
> java.lang.AssertionError: /joboverview.json did not contain valid json
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertNotNull(Assert.java:712)
> at
> org.apache.flink.runtime.webmonitor.history.HistoryServerTest.testFullArchiveLifecycle(HistoryServerTest.java:98)
> {code}
> Happened on a branch with unrelated changes [~Zentol].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
