[
https://issues.apache.org/jira/browse/FLINK-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950425#comment-15950425
]
ASF GitHub Bot commented on FLINK-6175:
---------------------------------------
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3655
Looks good to me overall. Instead of changing in the normal code path,
maybe it is a little bit less intrusive to use Mockito to change the field? For
example:
```
JobArchiveFetcherTask task = Whitebox.getInternal(archiveFetcher,
"fetcherTask");
JobArchiveFetcherTask spiedTask = Mockito.spy(task);
Whitebox.setInternal(archiveFetcher, "fetcherTask", spiedTask);
doAnswer(answer ->
latch.countDown()).doCallRealMethod().when(spiedTask).run();
```
> HistoryServerTest.testFullArchiveLifecycle fails
> ------------------------------------------------
>
> Key: FLINK-6175
> URL: https://issues.apache.org/jira/browse/FLINK-6175
> Project: Flink
> Issue Type: Test
> Components: Tests, Webfrontend
> Reporter: Ufuk Celebi
> Assignee: Chesnay Schepler
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/213933823/log.txt
> {code}
> estFullArchiveLifecycle(org.apache.flink.runtime.webmonitor.history.HistoryServerTest)
> Time elapsed: 2.162 sec <<< FAILURE!
> java.lang.AssertionError: /joboverview.json did not contain valid json
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertNotNull(Assert.java:712)
> at
> org.apache.flink.runtime.webmonitor.history.HistoryServerTest.testFullArchiveLifecycle(HistoryServerTest.java:98)
> {code}
> Happened on a branch with unrelated changes [~Zentol].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
