[ 
https://issues.apache.org/jira/browse/FLINK-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955050#comment-15955050
 ] 

ASF GitHub Bot commented on FLINK-5808:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/3670

    [FLINK-5808] Revert changes

    This reverts the changes around FLINK-5808 because they introduced 
follow-up issues.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink revert-5808

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3670
    
----
commit 153a2ecc4162760bac8538a578b5ed91bcd52b44
Author: Aljoscha Krettek <[email protected]>
Date:   2017-04-04T12:02:37Z

    Revert "[FLINK-5808] Add proper checks in 
setParallelism()/setMaxParallelism()"
    
    This reverts commit f31a55e08ddb7b4bc9e47577a187bac31ad42f4b.
    
    The fixes around FLINK-5808 introduced follow-up issues.

commit 66a3477284f357776d5edf14380a0a642286023c
Author: Aljoscha Krettek <[email protected]>
Date:   2017-04-04T12:03:26Z

    Revert "[FLINK-5808] Move max keygroup constants to ExecutionConfig"
    
    This reverts commit e4fbae36207c563363eed39886c24eea51d7db01.
    
    The fixes around FLINK-5808 introduced follow-up issues.

commit 8474db4c20ab35937c7640c3289f0bd7c3edc81b
Author: Aljoscha Krettek <[email protected]>
Date:   2017-04-04T12:04:40Z

    Revert "[FLINK-5808] Move default parallelism to StreamingJobGraphGenerator"
    
    This reverts commit 9cfae899358e0694c3ecedae1fad20e428a1d359.
    
    The fixes around FLINK-5808 introduced follow-up issues.

----


> Missing verification for setParallelism and setMaxParallelism
> -------------------------------------------------------------
>
>                 Key: FLINK-5808
>                 URL: https://issues.apache.org/jira/browse/FLINK-5808
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>    Affects Versions: 1.2.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.3.0, 1.2.1
>
>
> When {{setParallelism()}} is called we don't verify that it is <= than max 
> parallelism. Likewise, when {{setMaxParallelism()}} is called we don't check 
> that the new value doesn't clash with a previously set parallelism.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to