[
https://issues.apache.org/jira/browse/FLINK-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958555#comment-15958555
]
ASF GitHub Bot commented on FLINK-6270:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/3683#discussion_r110106044
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -39,10 +39,53 @@
key("taskmanager.jvm-exit-on-oom")
.defaultValue(false);
+ /** Size of memory buffers used by the network stack and the memory
manager (in bytes). */
+ public static final ConfigOption<Integer> MEMORY_SEGMENT_SIZE =
+ key("taskmanager.memory.segment-size")
+ .defaultValue(32768);
+
+ /**
+ * Amount of memory to be allocated by the task manager's memory
manager (in megabytes). If not
+ * set, a relative fraction will be allocated, as defined by {@link
#MANAGED_MEMORY_FRACTION}.
+ */
+ public static final ConfigOption<Long> MANAGED_MEMORY_SIZE =
+ key("taskmanager.memory.size")
+ .defaultValue(-1L);
--- End diff --
yes, but unfortunately, `.noDefaultValue` is only specified for
`ConfigOption<String>` - I'll change the comparisons to match against the
default though - that already looked like a strange pattern
> Port several network config parameters to ConfigOption
> ------------------------------------------------------
>
> Key: FLINK-6270
> URL: https://issues.apache.org/jira/browse/FLINK-6270
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.3.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Minor
>
> I'd like to port some memory and network buffers related config options to
> new {{ConfigOption}} instances before continuing with FLINK-4545. These
> include:
> * {{taskmanager.memory.size}}
> * {{taskmanager.memory.fraction}}
> * {{taskmanager.memory.off-heap}}
> * {{taskmanager.memory.preallocate}}
> * {{taskmanager.network.numberOfBuffers}}
> * {{taskmanager.memory.segment-size}}
> Some of these already existed as {{ConfigOption}} instances in
> {{MiniClusterConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
