[
https://issues.apache.org/jira/browse/FLINK-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958575#comment-15958575
]
ASF GitHub Bot commented on FLINK-6270:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/3683#discussion_r110108276
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala
---
@@ -350,23 +350,18 @@ class LocalFlinkMiniCluster(
def setMemory(config: Configuration): Unit = {
// set this only if no memory was pre-configured
- if (config.getInteger(ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY,
-1) == -1) {
+ if (config.getLong(TaskManagerOptions.MANAGED_MEMORY_SIZE) == -1L) {
--- End diff --
I'm tempted to replace these with a `config.contains()` call but then the
user would not be able to explicitly provide `-1` as the config option's value
which is possible and valid at the moment. I don't really want to break
existing behaviour though.
What do you think?
> Port several network config parameters to ConfigOption
> ------------------------------------------------------
>
> Key: FLINK-6270
> URL: https://issues.apache.org/jira/browse/FLINK-6270
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.3.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Minor
>
> I'd like to port some memory and network buffers related config options to
> new {{ConfigOption}} instances before continuing with FLINK-4545. These
> include:
> * {{taskmanager.memory.size}}
> * {{taskmanager.memory.fraction}}
> * {{taskmanager.memory.off-heap}}
> * {{taskmanager.memory.preallocate}}
> * {{taskmanager.network.numberOfBuffers}}
> * {{taskmanager.memory.segment-size}}
> Some of these already existed as {{ConfigOption}} instances in
> {{MiniClusterConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
