[ 
https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960490#comment-15960490
 ] 

ASF GitHub Bot commented on FLINK-6240:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3694#discussion_r110342899
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
 ---
    @@ -75,4 +75,13 @@ abstract class GeneratedAggregations extends Function {
         */
       def createOutputRow(): Row
     
    +  /**
    +    * merge two rows of accumulators into one row
    +    *
    +    * @param a one input row
    +    * @param b the other input row
    +    * @return a row of accumulators which contains the merged aggregated 
results
    +    */
    +  def mergeTwoRows(a: Row, b: Row): Row
    --- End diff --
    
    rename to `mergeAccumulators` or `mergeAccumulatorsPair`?


> codeGen dataStream aggregates that use AggregateAggFunction
> -----------------------------------------------------------
>
>                 Key: FLINK-6240
>                 URL: https://issues.apache.org/jira/browse/FLINK-6240
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to