[ 
https://issues.apache.org/jira/browse/FLINK-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960507#comment-15960507
 ] 

ASF GitHub Bot commented on FLINK-6240:
---------------------------------------

Github user shaoxuan-wang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3694#discussion_r110344806
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
 ---
    @@ -403,6 +403,41 @@ class CodeGenerator(
              |  }""".stripMargin
         }
     
    +    def generateMergeTwoRows(
    +        accTypes: Array[String],
    +        aggs: Array[String]): String = {
    +
    +      val sig: String =
    +        j"""
    +           |  public org.apache.flink.types.Row mergeTwoRows(
    +           |    org.apache.flink.types.Row a,
    +           |    org.apache.flink.types.Row b)
    +           |    """.stripMargin
    +      val merge: String = {
    +        for (i <- aggs.indices) yield
    +          j"""
    +             |    ${accTypes(i)} aAcc$i = (${accTypes(i)}) a.getField($i);
    +             |    ${accTypes(i)} bAcc$i = (${accTypes(i)}) b.getField($i);
    +             |    java.util.ArrayList<${accTypes(i)}> accumulators$i
    --- End diff --
    
    I was planning to remove `trait Accumulator` very soon, we cannot reuse the 
list after that.


> codeGen dataStream aggregates that use AggregateAggFunction
> -----------------------------------------------------------
>
>                 Key: FLINK-6240
>                 URL: https://issues.apache.org/jira/browse/FLINK-6240
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to