[
https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972908#comment-15972908
]
ASF GitHub Bot commented on FLINK-6242:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3735#discussion_r111984555
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala
---
@@ -97,12 +94,7 @@ class DataSetAggFunction(
}
// set agg results to output
- i = 0
- while (i < aggOutMapping.length) {
- val (out, in) = aggOutMapping(i)
- output.setField(out, aggregates(in).getValue(accumulators(in)))
- i += 1
- }
+ function.setAggregationResults(accumulators, output)
// set grouping set flags to output
if (intermediateGKeys.isDefined) {
--- End diff --
I think this should eventually be integrated with `setForwardFields()` as
well.
For now, we might leave it as it is.
> codeGen DataSet Goupingwindow Aggregates
> ----------------------------------------
>
> Key: FLINK-6242
> URL: https://issues.apache.org/jira/browse/FLINK-6242
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
