[
https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973411#comment-15973411
]
ASF GitHub Bot commented on FLINK-6242:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3735#discussion_r111991399
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -407,32 +513,56 @@ class CodeGenerator(
accTypes: Array[String],
aggs: Array[String]): String = {
- val sig: String =
+ val sigHelper: String =
j"""
- | public org.apache.flink.types.Row mergeAccumulatorsPair(
+ | public final org.apache.flink.types.Row
mergeAccumulatorsPairHelper(
| org.apache.flink.types.Row a,
- | org.apache.flink.types.Row b)
+ | org.apache.flink.types.Row b,
+ | java.lang.Integer offset)
""".stripMargin
- val merge: String = {
+ val mergeHelper: String = {
for (i <- aggs.indices) yield
j"""
| ${accTypes(i)} aAcc$i = (${accTypes(i)}) a.getField($i);
- | ${accTypes(i)} bAcc$i = (${accTypes(i)}) b.getField($i);
+ | ${accTypes(i)} bAcc$i = (${accTypes(i)}) b.getField($i +
offset);
--- End diff --
`b.getField($i + offset)` -> `b.getField(${i + offset})`
> codeGen DataSet Goupingwindow Aggregates
> ----------------------------------------
>
> Key: FLINK-6242
> URL: https://issues.apache.org/jira/browse/FLINK-6242
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
