[ 
https://issues.apache.org/jira/browse/FLINK-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047507#comment-14047507
 ] 

Fabian Hueske commented on FLINK-984:
-------------------------------------

Regarding the second point, I agree with Markus. Distinct is not a grouping 
operation, IMO. Although it blows up the DataSet API a bit, I think adding 
{{distinct()}} to {{DataSet}} is the better option.



> Distinct operator for POJO DataSets without KeySelector and on 
> UnsortedGrouping
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-984
>                 URL: https://issues.apache.org/jira/browse/FLINK-984
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Priority: Minor
>
> Two issues regarding the distinct operator:
> - The distinct operator does not support {{distinct()}} with POJO datasets. I 
> think it should be possible to implement a reflection based KeySelector which 
> selects all public fields as key?
> - All other grouped operators work by {{groupBy(GROUPING).operator(...)}} 
> whereas the distinct operator does {{distinct(GROUPING)}}. I think it would 
> be more consistent to allow {{groupBy(GROUPING).distinct()}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to