[
https://issues.apache.org/jira/browse/FLINK-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053542#comment-14053542
]
ASF GitHub Bot commented on FLINK-984:
--------------------------------------
GitHub user markus-h opened a pull request:
https://github.com/apache/incubator-flink/pull/61
[FLINK-984] Extension of the API for distinct for Key Expressions,
additional testcases
I extended the API for the distinct operator to also work on POJOs using
either key expressions or by using plain distinct() selecting all public fields.
I also added some more testcases for the operator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markus-h/incubator-flink distinct_extension
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit dd7aa11b1df58c316c420ffccfe704afdb4f8ed0
Author: Markus Holzemer <[email protected]>
Date: 2014-07-01T12:27:56Z
Extension of the API for distinct for Key Expressions, additional testcases
----
> Distinct operator for POJO DataSets without KeySelector and on
> UnsortedGrouping
> -------------------------------------------------------------------------------
>
> Key: FLINK-984
> URL: https://issues.apache.org/jira/browse/FLINK-984
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: Markus Holzemer
> Priority: Minor
>
> Two issues regarding the distinct operator:
> - The distinct operator does not support {{distinct()}} with POJO datasets. I
> think it should be possible to implement a reflection based KeySelector which
> selects all public fields as key?
> - All other grouped operators work by {{groupBy(GROUPING).operator(...)}}
> whereas the distinct operator does {{distinct(GROUPING)}}. I think it would
> be more consistent to allow {{groupBy(GROUPING).distinct()}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
