Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/102#discussion_r16664393
  
    --- Diff: LICENSE ---
    @@ -251,8 +251,26 @@ THE SOFTWARE.
      BSD-style Licenses
     -----------------------------------------------------------------------
     
    +The Apache Flink project depends on and/or bundles the following components
    +under BSD-style licenses
    +
     (3-clause BSD license)
      - D3 (http://d3js.org/) - Copyright (c) 2010-2014, Michael Bostock
    + - Kryo (https://github.com/EsotericSoftware/kryo) - Copyright (c) 2008, 
Nathan Sweet
    + - LevelDB (http://code.google.com/p/leveldb/) - Copyright (c) 2011, The 
LevelDB Authors
    + - Memcached (https://github.com/memcached/memcached) - Copyright (c) 
2003, Danga Interactive, Inc.
    + - Redis (http://redis.io/) - Copyright (c) 2009, Salvatore Sanfilippo and 
Pieter Noordhuis
    +
    +(BSD-style License)
    + - Hamcrest (https://code.google.com/p/hamcrest/) - Copyright (c) 
2000-2006, www.hamcrest.org
    + 
    +(BSD-like License)
    + - Scala Library (http://www.scala-lang.org/) - Copyright (c) 2002-2014 
EPFL, Copyright (c) 2011-2014 Typesafe, Inc.
    + - Scala Compiler (BSD-like) - (http://www.scala-lang.org/) - Copyright 
(c) 2002-2014 EPFL, Copyright (c) 2011-2014 Typesafe, Inc.
    + - Scala Compiler Reflect (BSD-like) - (http://www.scala-lang.org/) - 
Copyright (c) 2002-2014 EPFL, Copyright (c) 2011-2014 Typesafe, Inc.
    + - ASM (BSD-like) - (http://asm.ow2.org/) - Copyright (c) 2000-2011 INRIA, 
France Telecom
    +
    +(Below is the 3-clause BSD license)
     
    --- End diff --
    
    You are adding these dependencies to the LICENSE file, which ends up in the 
source distribution.
    
    You probably want to put them into the DEPENDENCIES file? and as well into 
the `flink-dist/src/main/flink-bin/` directory?
    @StephanEwen is our expert on crafting license files ;) Ask him if in doubt


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to